Skip to content

fix(schema-compiler): Fix BigQuery queries datetime/timestamp comparisons #9683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 19, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 17, 2025

This is an attempt to fix BigQuery queries that fail with:

Error: No matching signature for operator < for argument types: DATETIME, TIMESTAMP
  Signature: T1 < T1
    Unable to find common supertype for templated argument <T1>
      Input types for <T1>: {TIMESTAMP, DATETIME} at [6:85]

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
@KSDaemon KSDaemon force-pushed the fix/bigquery-timestamps branch from 7c3fe78 to 444c95d Compare June 17, 2025 15:29
@KSDaemon KSDaemon marked this pull request as ready for review June 17, 2025 16:45
@KSDaemon KSDaemon requested review from a team as code owners June 17, 2025 16:45
@KSDaemon KSDaemon force-pushed the fix/bigquery-timestamps branch from e5acc27 to 69f5184 Compare June 18, 2025 12:14
@waralexrom waralexrom force-pushed the fix/bigquery-timestamps branch from 69f5184 to c0972cd Compare June 19, 2025 10:22
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (17570d4) to head (c0972cd).
Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9683       +/-   ##
===========================================
+ Coverage        0   84.17%   +84.17%     
===========================================
  Files           0      230      +230     
  Lines           0    85112    +85112     
===========================================
+ Hits            0    71639    +71639     
- Misses          0    13473    +13473     
Flag Coverage Δ
cubesql 84.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@KSDaemon KSDaemon merged commit 525932c into master Jun 19, 2025
78 checks passed
@KSDaemon KSDaemon deleted the fix/bigquery-timestamps branch June 19, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants