Skip to content

shouldFetchDryRun should consider changes made to filters #3552

Open
@john-nexkey

Description

@john-nexkey

Describe the bug
When I modify filters using updateFilters methods within QueryBuilder, a dry run does not occur as expected. Adding filters to the existing shouldFetchDryRun array (['measures', 'dimensions', 'timeDimensions']) fixes the issue.

To Reproduce
Steps to reproduce the behavior:

  1. Call updateFilters.add QueryBuilder (@cubejs-client/react) to modify filters
  2. A dry run does not occur

Expected behavior
I expect a filter change to prompt a dry run.

Screenshots
https://github.com/cube-js/cube.js/blob/master/packages/cubejs-client-react/src/QueryBuilder.jsx#L485-L488

Version:
0.28.43

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    client:reactIssues relating to the React client SDKhelp wantedCommunity contributions are welcome.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions