Skip to content

Conversation

whoburg
Copy link
Collaborator

@whoburg whoburg commented May 9, 2016

@bqpd, please review and add additional commits if you see ways to improve

import numpy as np
import matplotlib.pyplot as plt
xmin = np.linspace(0.01, 3, 30)
# TODO changing 0.01 to 0 above results in an error -- suspected GPkit bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove_unbounded_zeros to use a <= 0 constraint.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true - good point

@whoburg
Copy link
Collaborator Author

whoburg commented May 13, 2016

responded to code review.

@@ -18,8 +18,7 @@ The full GP, derived from the Python implementation of the model, is
from simple_gp import SimpleGP
m = SimpleGP()
with open("gp.generated.tex", "w") as f:
f.write(m._repr_latex_())
# TODO wish model name didn't get printed in the above
f.write("$%s$" % m.latex(excluded=["models", "units"]))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bqpd note the need for dollar signs here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@bqpd
Copy link
Contributor

bqpd commented May 13, 2016

Looks good to me! Do we want any tests?

@bqpd
Copy link
Contributor

bqpd commented Jun 18, 2016

@whoburg, I think this is ready to merge?

@whoburg
Copy link
Collaborator Author

whoburg commented Sep 11, 2016

@mjburton11, you've been using markdown a lot. Do you see any improvements that could be made to this template before we merge? (e.g. maybe your gen_tex_fig)?

Let's all start new projects from this template and hopefully thereby make it better over time.

@mjburton11
Copy link

Just added gen_tex_fig. The other really useful thing that may be more difficult to represent here is the function I use to generate model latex if the model has submodels. If you think that should be added here let me know.

\begin{figure}[h!]
\label{fig:sweep}
\begin{center}
\includegraphics{simple_sweep.pdf}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whoburg, @bqpd when I removed [scale=0.5] it worked just fine. Now have 3 ways of putting a figure in the md.

@whoburg
Copy link
Collaborator Author

whoburg commented Sep 21, 2016

@mjburton11 is tackling convexengineering/gpkit#890, and then this should be good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
close