Skip to content

Conversation

@exigow
Copy link
Contributor

@exigow exigow commented Jun 25, 2025

Description

I had the exact same issue as in #6020 when setting up the extension locally. Every attempt to log in ended in a freeze (100% reproducible).

My change removes the Desktop class and replaces it with a built-in OS-agnostic BrowserUtil. Removing this class also removes the use of the SLF4J logger, which was the cause of the mentioned exceptions.

Checklist

  • ✅ I've read the contributing guide
  • ✅ The relevant docs, if any, have been updated or created
  • ✅ The relevant tests, if any, have been updated or created
@exigow exigow requested a review from a team as a code owner June 25, 2025 13:14
@exigow exigow requested review from sestinj and removed request for a team June 25, 2025 13:14
@netlify
Copy link

netlify bot commented Jun 25, 2025

👷 Deploy request for continuedev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3831a0b
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 25, 2025
@github-actions
Copy link

github-actions bot commented Jun 25, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@recurseml
Copy link

recurseml bot commented Jun 25, 2025

✨ No issues found! Your code is sparkling clean! ✨

Need help? Join our Discord for support!
https://discord.gg/NCpkJ4kF

@exigow
Copy link
Contributor Author

exigow commented Jun 25, 2025

I have read the CLA Document and I hereby sign the CLA

@Patrick-Erichsen
Copy link
Collaborator

Wow, didn't realize we had a hand-rolled browser util implementation when there is a built-in from IntelliJ. This was likely a very old artifact from one of the original OS contributors that helped us set up the original JetBrains plugin.

Great find!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 25, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 880b254 into continuedev:main Jun 25, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 22, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

3 participants