Update TrueBrain/actions-flake8 github action to v2#2073
Merged
Conversation
peternewman
approved these changes
Sep 22, 2021
Collaborator
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
LGTM, just a query about pinning to a specific version (and therefore requiring us to keep upgrading in future).
bwitt
changed the title
TrueBrain/actions-flake8 to latest and pin flake8 to current latestTrueBrain/actions-flake8 github action to v2
Collaborator
|
@DimitriPapadopoulos do you want to re-review too? |
Collaborator
|
Perfect. And indeed if the CI fails on us too often, we may have to reconsider pinning versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update github action
Flake8 with annotationstov2