Ensure that filemode is set for device nodes #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zvonkok for the Kata use case the rust implementation must also be updated. |
This change ensures that the filemode for a CDI device is properly set from the host device node when adding devices to the CDI spec. Without this the device node permissions are 000 in the container under certain conditions (such as Kata). Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-extra-device-info
branch
from
4120810 to
8288672
Compare
klihub
approved these changes
Jun 19, 2025
bart0sh
reviewed
Jun 23, 2025
| @@ -65,22 +86,31 @@ func (d *DeviceNode) fillMissingInfo() error { | |||
| return nil | |||
There was a problem hiding this comment.
Should we also set d.FileMode here?
There was a problem hiding this comment.
What would you set it to in this case?
There was a problem hiding this comment.
This logic is an early return meaning that we don't query the device node. I can make things a bit more consistent though. Let me see what I can come up with.
bart0sh
reviewed
Jun 23, 2025
| d.FileMode = &di.fileMode | ||
| } | ||
|
|
||
| if d.Type == "p" { |
There was a problem hiding this comment.
Suggested change
| if d.Type == "p" { | |
| if d.Type == fifoDevice { |
There was a problem hiding this comment.
We use "p" elsewhere in this function. I don't mind changing this to a constant, but would do so consistently across this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the filemode for a CDI device is properly set from the host device node when adding devices to the CDI spec.
Without this the device node permissions are 000 in the container under certain conditions (such as Kata).
See also NVIDIA/nvidia-container-toolkit#960