Skip to content

handle ports race condition by returning 3000#41

Merged
pmuellr merged 1 commit into
masterfrom
pmuellr/issue-40-ports
Mar 26, 2019
Merged

handle ports race condition by returning 3000#41
pmuellr merged 1 commit into
masterfrom
pmuellr/issue-40-ports

Conversation

@pmuellr

@pmuellr pmuellr commented Mar 26, 2019

Copy link
Copy Markdown
Member

fixes #40

This is a very simple to fix to the problem with ports where it
will occaisonally throw an error:

The fix is to catch the error and use port 3000. Not great, but should
handle some cases where this was a problem.

An alternate fix to try would be to try fetching the port again, probably
in a loop (with some limit), in hopes of getting a value from ports.

fixes #40

This is a very simple to fix to the problem with ports where it
will occaisonally throw an error:

- hoodiehq-archive/node-ports#4

The fix is to catch the error and use port 3000.  Not great, but should
handle some cases where this was a problem.

An alternate fix to try would be to try fetching the port again, probably
in a loop (with some limit), in hopes of getting a value from ports.
@pmuellr pmuellr merged commit b07a59e into master Mar 26, 2019
@pmuellr pmuellr deleted the pmuellr/issue-40-ports branch March 26, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant