helm: recreate daemonset pod when configmap changes#812
Merged
Conversation
Signed-off-by: Jinna C <jinnatim@gmail.com>
kkourt
approved these changes
Mar 28, 2023
kkourt
left a comment
kkourt
left a comment
Contributor
There was a problem hiding this comment.
I think that makes sense. Would be nice if @michi-covalent had a look as well.
Looking into this, we could also set the config map as immutable but that's orthogonal to this patch.
Thanks!
Contributor
|
LGTM thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the helm upgrade with new configmap changes. the daemonset pod is not recreated to retrieve the new configmap.
The readconfig function only read on pod start https://github.com/cilium/tetragon/blob/main/cmd/tetragon/main.go#L542
to make Tetragon restart and retrieve the new configuration. Kubernetes annotation helps determine whenever the pod needs to be recreated.