Skip to content

Pass Namespace in metrics options instead of prefixing metric names#1228

Merged
1 commit merged into
mainfrom
unknown repository
Jul 14, 2023
Merged

Pass Namespace in metrics options instead of prefixing metric names#1228
1 commit merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 14, 2023

Copy link
Copy Markdown

This is a non-functional change.

This is a non-functional change.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@ghost
ghost self-requested a review as a code owner July 14, 2023 09:38
@ghost
ghost requested a review from tpapagian July 14, 2023 09:38
@ghost ghost added the area/metrics Related to prometheus metrics label Jul 14, 2023

@tpapagian tpapagian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghost
ghost merged commit 6f694cf into cilium:main Jul 14, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metrics Related to prometheus metrics

1 participant