pkg/filters: make field filters work with snake case fields#1223
Merged
willfindlay merged 1 commit intoJul 14, 2023
Conversation
kkourt
approved these changes
Jul 14, 2023
Protobuf does not support snake case in the JSON representation of FieldMasks. This is a problem for us because our canonical representation of fields is in snake_case and we don't want to create confusion. To make things consistent, this patch introduces a hack to perform the snake case to camel case conversion just before we unmarshal from JSON. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
force-pushed
the
pr/willfindlay/field-filters-support-snake-case
branch
from
July 14, 2023 13:28
068bb58 to
8cda5ea
Compare
willfindlay
added
the
release-note/minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf does not support snake case in the JSON representation of FieldMasks. This is a problem for us because our canonical representation of fields is in snake_case and we don't want to create confusion. To make things consistent, this patch introduces a hack to perform the snake case to camel case conversion just before we unmarshal from JSON.