Add common types to CRD argument parsing#1190
Merged
Merged
Conversation
Kprobe and tracepoint arguments can be specified with a type. In some cases some common types – int64, int32, long, unsigned long and long – were missing from the mapping from their string representations to the internal type enum. This caused warnings to be displayed if these types were used in a CRD to specify the types of arguments. This commit adds these common types. Signed-off-by: Kevin Sheldrake <kevin.sheldrake@isovalent.com>
kkourt
approved these changes
Jul 6, 2023
olsajiri
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kprobe and tracepoint arguments can be specified with a type. In some cases some common types – int64, int32, long, unsigned long and long – were missing from the mapping from their string representations to the internal type enum. This caused warnings to be displayed if these types were used in a CRD to specify the types of arguments.
This commit adds these common types.