contrib: add a Docker images digest checker#1185
Merged
Merged
Conversation
mtardy
force-pushed
the
pr/mtardy/digest-checker
branch
10 times, most recently
from
July 5, 2023 09:29
2d4531d to
399ec48
Compare
Add a shell script and its workflow to automatically detect when we use arch-restricted Docker images when we could use multi-arch ones. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Go image used to build gops was manually updated to an arch-specific digest of that tag. This replaces it with the generic digest for the multi-arch image. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/digest-checker
branch
from
July 5, 2023 09:32
399ec48 to
2d21faf
Compare
mtardy
marked this pull request as ready for review
July 5, 2023 09:33
willfindlay
approved these changes
Jul 5, 2023
Member
Author
|
My only concern is that this thing gets rate limited by Dockerhub when trying to fetch the manifest from there (our images are on quay). Let's see how it behaves, it should run rarely given the triggering rules. Let's 🚢 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a shell script and its workflow to automatically detect when we use arch-restricted Docker images when we could use multi-arch ones.