Make ReturnArgAction optional#1181
Merged
Merged
Conversation
The ReturnArgAction was added to the KProbeSpec to allow actions to be taken on the return values from hooked functions. It was specified as an enumeration in order to constrain its use to the supported actions, namely: Post, TrackSock and UntrackSock. This has the unintended consequence of making it non-optional through K8S validation. This commit makes the ReturnArgAction optional. Signed-off-by: Kevin Sheldrake <kevin.sheldrake@isovalent.com>
olsajiri
reviewed
Jul 3, 2023
olsajiri
left a comment
olsajiri
left a comment
Contributor
There was a problem hiding this comment.
could you please add the 'fixes: commit' tag for reference?
Contributor
Author
I don't think there's an issue for this; just a Slack thread. |
Contributor
I mean the commit number that broke it |
olsajiri
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReturnArgAction was added to the KProbeSpec to allow actions to be taken on the return values from hooked functions. It was specified as an enumeration in order to constrain its use to the supported actions, namely: Post, TrackSock and UntrackSock. This has the unintended consequence of making it non-optional through K8S validation.
This commit makes the ReturnArgAction optional.
Fixes: f851189