Skip to content

Revert sigstore/cosign-installer update and ignore it#1161

Merged
mtardy merged 2 commits into
mainfrom
pr/mtardy/cosign-hell
Jun 27, 2023
Merged

Revert sigstore/cosign-installer update and ignore it#1161
mtardy merged 2 commits into
mainfrom
pr/mtardy/cosign-hell

Conversation

@mtardy

@mtardy mtardy commented Jun 27, 2023

Copy link
Copy Markdown
Member

No description provided.

mtardy added 2 commits June 27, 2023 19:04
Revert update from ac11ac3 that broke
the build and is difficult to test pre-merge.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy
mtardy requested review from a team and willfindlay as code owners June 27, 2023 17:08
@mtardy

mtardy commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

btw a lot of tests will fail because the image build is broken (this patch is fixing it) and it is using pull_request_target as trigger.

@willfindlay willfindlay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@mtardy

mtardy commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

Let's not wait for the tests to fail and merge this directly.

@mtardy
mtardy merged commit db2649d into main Jun 27, 2023
@mtardy
mtardy deleted the pr/mtardy/cosign-hell branch June 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants