tetragon: Remove unused cgo code for reading perf events#1061
Conversation
57a4e72 to
f54eff1
Compare
olsajiri
changed the title
|
we might need to remove https://tetragon.cilium.io/docs/faq/#go-compiler-is-complaining-about-missing-symbols-in-pkgbpf, we can leave it here for now but remove it in the future, and also simplify tetra compilation on Linux. |
kevsecurity
left a comment
kevsecurity
left a comment
There was a problem hiding this comment.
If it passes all the tests, LGTM!
We switched to cilium/ebpf for reading perf ring buffer some time ago [1], but we did not remove the old ring buffer code, removing it now. Keeping just PerfEventConfig type used by observer, attr objects used by map_linux.go and few helper functions used by other code. [1] 6dd4ee1 ("pkg/observer: remove old runEvents code") Signed-off-by: Jiri Olsa <jolsa@kernel.org>
mtardy
left a comment
mtardy
left a comment
There was a problem hiding this comment.
Nice to remove that! Thanks!
we might need to remove https://tetragon.cilium.io/docs/faq/#go-compiler-is-complaining-about-missing-symbols-in-pkgbpf, we can leave it here for now but remove it in the future, and also simplify tetra compilation on Linux.
If you can just open an issue when this merges so that we don't forget about these items. 😇
sure ;-) #1077 |
4 participants
We switched to cilium/ebpf for reading perf ring buffer some
time ago [1], but we did not remove the old ring buffer code,
removing it now.
Keeping just PerfEventConfig type used by observer, attr objects
used by map_linux.go and few helper functions used by other code.
[1] 6dd4ee1 ("pkg/observer: remove old runEvents code")
Signed-off-by: Jiri Olsa jolsa@kernel.org