Rename argRateLimit to rateLimit#1057
Merged
Merged
Conversation
In the previous commit, the rate limit parameter to matchActions was incorrectly specified as argRateLimit (but was correct in documentation). This commit changes that parameter to the correct rateLimit. No releases have occurred since the commit. This change shouldn't have a detrimental or regressive effect. Also, updated the example datagram.yaml tracing policy to include the rateLimit parameter. Also fixes a potential overflow in the rateLimit argument. Signed-off-by: Kevin Sheldrake <kevin.sheldrake@isovalent.com>
kevsecurity
force-pushed
the
pr/kevsecurity/argRateLimit-rateLimit
branch
from
June 7, 2023 09:35
c4fe6be to
1d9284b
Compare
kkourt
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous commit, the rate limit parameter to matchActions was incorrectly specified as argRateLimit (but was correct in documentation). This commit changes that parameter to the correct rateLimit. No releases have occurred since the commit. This change shouldn't have a detrimental or regressive effect. Also, updated the example datagram.yaml tracing policy to include the rateLimit parameter.
Also fixes a potential overflow in the rateLimit argument.