tetragon: Adding missing tid setup to HandleGenericEvent#1027
Merged
Conversation
Member
|
That internal.GetProcessCopy() inside HandleGenericEvent() may endup resetting the tid that was set before hence the failures. I'm fine merging this as it is now... so we don't change too much layouts, then we can improve later |
We set tid for process part of the event to the tid value we received from kprobe/uprobe/tracepoint event. We missed tid update in HandleGenericEvent function which is called from Retry eventcache events callbacks. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
changed the title
olsajiri
marked this pull request as ready for review
May 25, 2023 07:08
kkourt
approved these changes
May 30, 2023
mtardy
approved these changes
May 30, 2023
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set tid for process part of the event to the tid value
we received from kprobe/uprobe/tracepoint event.
We missed it in HandleGenericEvent which is called from
Retry eventcache callback.