tests: rewrite pkg/sensors/exec:TestExitCode#1015
Merged
Merged
Conversation
The test was calling JsonTestCheck multiple times resulting in the deletion of the logs if one of the tests before the last one failed. Now test also uses the eventchecker framework and is simpler. The test was also flaky, not sure this will fix the issue but I could reproduce the failure after a hundred runs with the previous code while I could not at the moment with this one after 200+ runs. At least we will have the failure logs if this test continues to fail in the future. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
requested review from
kkourt,
olsajiri and
willfindlay
and removed request for
olsajiri
May 22, 2023 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might fix #1014.
The test was calling JsonTestCheck multiple times resulting in the deletion of the logs if one of the tests before the last one failed. Now test also uses the eventchecker framework and is simpler.
The test was also flaky, not sure this will fix the issue but I could reproduce the failure after a hundred runs with the previous code while I could not at the moment with this one after 200+ runs. At least we will have the failure logs if this test continues to fail in the future.