Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

da: fix batcher submit#511

Merged
tuxcanfly merged 2 commits into
celestia-developfrom
tux/fix-celestia-node-client
Aug 26, 2025
Merged

da: fix batcher submit#511
tuxcanfly merged 2 commits into
celestia-developfrom
tux/fix-celestia-node-client

Conversation

@tuxcanfly

Copy link
Copy Markdown
Collaborator

Description

As mentioned in #504 batcher submit has a few issues, i.e. which are fixed:

  • remove duplicate cancel()
  • consistent namespace parsing
  • restore gas price txconfig

Thanks @kien-rise

* remove duplicate cancel
* consistent namespace parsing
* restore gas price txconfig
@tuxcanfly tuxcanfly self-assigned this Aug 21, 2025
@tuxcanfly tuxcanfly requested a review from Ferret-san August 21, 2025 08:49
@kien-rise

Copy link
Copy Markdown

Give me a moment, let me request more changes.

Comment thread op-batcher/batcher/driver.go Outdated
@kien-rise

Copy link
Copy Markdown

nit, but it will be great if you help resolving this request 👇 in the same PR as well. Thanks!

https://github.com/celestiaorg/optimism/pull/504/files#r2297793712

@tuxcanfly tuxcanfly requested a review from kien-rise August 26, 2025 13:54
Comment thread op-batcher/batcher/driver.go

@kien-rise kien-rise left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me (the last comment does not require any actions)

@tuxcanfly tuxcanfly merged this pull request into celestia-develop Aug 26, 2025
17 of 39 checks passed
@tuxcanfly tuxcanfly deleted the tux/fix-celestia-node-client branch August 26, 2025 14:23
tuxcanfly added a commit that referenced this pull request Aug 26, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)
tuxcanfly added a commit that referenced this pull request Aug 26, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)
tuxcanfly added a commit that referenced this pull request Sep 9, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Sep 9, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Sep 11, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Sep 23, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Oct 2, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Oct 6, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)
tuxcanfly added a commit that referenced this pull request Oct 11, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
tuxcanfly added a commit that referenced this pull request Oct 11, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
Ferret-san pushed a commit that referenced this pull request Nov 7, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
tuxcanfly added a commit that referenced this pull request Dec 2, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
tuxcanfly added a commit that referenced this pull request Dec 2, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
tuxcanfly added a commit that referenced this pull request Dec 3, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config

gh: delete dependabot
nuke-web3 pushed a commit that referenced this pull request Dec 3, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config
tuxcanfly added a commit that referenced this pull request Dec 19, 2025
build(deps): update go-da to v0.1.0

build(deps): update go-da to v0.2.0; add ctx

da: add cli flags for da config

da: add get timeout to da client

build(deps): bump local-celestia-devnet to v0.12.7

fix(cli): fix da rpc check

fix(cli): check return err

fix(da): blob data source reuse DataFromEVMTransactions

da: upgrade to go-da v0.5.0

feat(op-batcher): support disable eth fallback

chore(op-batcher): refactor EthFallbackDisabledFlagName

da: use env auth token if set

feat: enable multi frame txs and frame size setting for calldata txs

chore: add log for multiframetxs setting

da: try using blobdata for eth fallback

da: add gas price flag (#451)

da: reuse useblobs for multiframetxs (#452)

Add Github CI (#472)

Cleanup Github CI workflow (#478)

feat: allow to toggle Celestia in op-batcher and op-node (#498)

feat: add op-celestia indexer (#503)

fix: init op-node client

da: use celestia-node client (#504)

da: fix batcher submit (#511)

feat(op-celestia/indexer): add indexed l2 block status (#514)

da: optionally support new tx client (#517)

da: fix celestia config

da: fix celestia enabled

da: update celestia-node v0.26.4

da: log celestia config

gh: delete dependabot

feat: `op-celestia-indexer` support for 4844 blob indexing (#530)

Co-authored-by: Javed Khan <tuxcanfly@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants