-
Notifications
You must be signed in to change notification settings - Fork 18
Adding more SDK Support #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a setup instructions
…-server into cont-regression
…t in Percy integration
Sync with main
Cont regression
… in PERCY_INSTRUCTIONS
…ode.js instructions
++ enhancing instructions
LGTM... |
Vishalan
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the BrowserStack SDK to support Percy visual testing, along with refactoring and expanding the type definitions for supported frameworks and languages. The changes include adding Percy-specific instructions, enabling Percy configuration in the SDK setup, and improving type safety with enums.
Percy Visual Testing Support:
src/tools/bstack-sdk.ts
: AddedenablePercy
parameter to thebootstrapProjectWithSDK
function and updated logic to handle Percy-specific instructions. Throws an error if Percy is unsupported for the detected configuration. [1] [2]src/tools/sdk-utils/instructions.ts
: UpdatedgenerateBrowserStackYMLInstructions
to include Percy-related fields whenenablePercy
is true. [1] [2]src/tools/sdk-utils/percy/constants.ts
: Added detailed Percy setup instructions for various languages and frameworks, including Java, Node.js, WebdriverIO, and C#.src/tools/sdk-utils/percy/instructions.ts
: Implemented functions to retrieve and format Percy-specific instructions based on the user's configuration.Type Safety Enhancements:
src/tools/sdk-utils/types.ts
: Refactored types for supported languages, automation frameworks, and testing frameworks into enums for improved type safety and extensibility.src/tools/bstack-sdk.ts
: Updated function signatures and validation to use the new enums. [1] [2]SDK Setup Improvements:
src/tools/sdk-utils/commands.ts
: Added a utility to generate language-dependent prefix commands for SDK setup, including Maven and Gradle instructions for Java frameworks.These changes collectively enhance the SDK's functionality, making it more robust and user-friendly while enabling visual testing capabilities with Percy.