fix: snapshot and restore Safe nonce#77
Merged
Merged
Conversation
Co-authored-by: Emiliano Bonassi <emiliano@conduit.xyz>
mdehoog
approved these changes
Apr 18, 2024
tynes
reviewed
Apr 18, 2024
|
|
||
| abstract contract MultisigBase is Simulator { | ||
| IMulticall3 internal constant multicall = IMulticall3(MULTICALL3_ADDRESS); | ||
| bytes32 internal constant SAFE_NONCE_SLOT = bytes32(uint256(5)); |
Contributor
There was a problem hiding this comment.
There is risk this will collide with another value that is automatically assigned by solc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently merged #72. Prior to this PR, foundry did not simulate the transaction, and just logged the data needed to generate the tenderly sim. As a result, when forge called
safe.nonce()at the very end of the solidity script, it matched what was on the actual chain.In that PR, we modified the scripts so forge always applies the required state overrides and simulates the transaction. This was done so we can use the state diff recording cheats in foundry and make assertions on the diff.
However, the actual logging of the
Data to sign:that's in the terminal callssafe.nonce()after the foundry simulation, so it's one too high.This PR snapshots the safe nonce prior to simulation and restores it after, so the data to sign is corrected logged.