Nested multisig refactor: have all multisigs submit approveHash#30
Merged
Conversation
added 2 commits
July 19, 2023 09:54
mdehoog
commented
Jul 19, 2023
| bytes32 s = bytes32(0); | ||
| bytes32 r = bytes32(uint256(uint160(msg.sender))); | ||
| _signatures = bytes.concat(_signatures, abi.encodePacked(r, s, v)); | ||
| } |
Author
There was a problem hiding this comment.
disables the ability for a final signer can submit the tx... now a threshold of signatures must be collected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
NestedMultisigBuilderhasthreshold - 1sub-multisigs submitapproveHash, and the final multisig executes the tx. This PR refactors that such that all sub-multisig perform the same steps: collect signatures, have a facilitator submit anapproveHashtx.Then finally a facilitator can execute the final tx after a threshold of hashes have been approved. This essentially removes
step 3, replacing it with a much simplerstep 4.Also renames the methods for simplicity:
signApproval->signexecuteApproval->approvesignTransaction-> REMOVEDrunTransaction->run