[mainnet] Deploy the newly updated Smart Escrow Contract#180
Conversation
| NESTED_SAFE=0x0a7361e734cf3f0394B0FC4a45C74E7a4Ec70940 | ||
| START=1720674000 | ||
| CLIFF_START=1724976000 | ||
| END=1882764000 |
There was a problem hiding this comment.
Needs to be July 11, 2029 : 1878462000
There was a problem hiding this comment.
Updated to reflect updated END time.
| include .env | ||
|
|
||
| .PHONY: deploy-new-implementation | ||
| deploy-new-implementation: |
There was a problem hiding this comment.
worth just adding a --verify to see if that works and don't have to go through the separate verification step
anikaraghu
left a comment
anikaraghu
left a comment
There was a problem hiding this comment.
LGTM thanks! checked agains that reference you had put together for reviewers - btw can you also add the cliffStart to it?
| BENEFICIARY_OWNER=0x6e1DFd5C1E22A4677663A81D24C6BA03561ef0f6 | ||
| NESTED_SAFE=0x0a7361e734cf3f0394B0FC4a45C74E7a4Ec70940 | ||
| START=1720674000 | ||
| CLIFF_START=1724976000 |
There was a problem hiding this comment.
this is Fri Aug 30 2024 00:00:00 GMT+0000 - what should I compare that against?
There was a problem hiding this comment.
Confirmed by Ben, based on date of first token received at Nested Multisig: https://optimistic.etherscan.io/tx/0x6d771624ecbff8704edfc5cbf3bff57b8bac9584775457b44e9872081cd0a733
…scrow.s.sol Co-authored-by: anikaraghu <anika.raghuvanshi@gmail.com>
cb-heimdall
dismissed
anikaraghu’s stale review
Approved review 2136966412 from anikaraghu is now dismissed due to new commit. Re-request for approval.
✅ Heimdall Review Status
|
|
🔥 |
3 participants
The escrow contract was updated with this PR: base/contracts#81
And audited in this PR: base/contracts#85