Skip to content

fix(CHAIN-1883): initialize oracle signers during initialization of Solana program#74

Merged
jackchuma merged 9 commits into
mainfrom
jack/init-oracle-signers
Aug 19, 2025
Merged

fix(CHAIN-1883): initialize oracle signers during initialization of Solana program#74
jackchuma merged 9 commits into
mainfrom
jack/init-oracle-signers

Conversation

@jackchuma

Copy link
Copy Markdown
Collaborator

No description provided.

@cb-heimdall

cb-heimdall commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
@jackchuma jackchuma requested review from mdehoog and xenoliss August 19, 2025 13:38
Comment thread solana/programs/bridge/src/common/state/bridge.rs Outdated
}

#[derive(Debug, Clone, PartialEq, Eq, InitSpace, AnchorSerialize, AnchorDeserialize)]
pub struct Config {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we embed this into the Bridge directly?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered this but the eip-1559 config is different in the Bridge account

Comment thread solana/programs/bridge/src/common/state/bridge.rs Outdated
Comment thread solana/programs/bridge/src/common/instructions/initialize.rs Outdated
Comment thread solana/programs/bridge/src/common/state/bridge.rs Outdated
Comment thread solana/programs/bridge/src/common/instructions/oracle_signers.rs
@jackchuma jackchuma requested a review from xenoliss August 19, 2025 17:15
@jackchuma jackchuma merged commit 4b2d459 into main Aug 19, 2025
3 checks passed
@jackchuma jackchuma deleted the jack/init-oracle-signers branch August 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants