Skip to content

fix(CHAIN-1873): remove unused instruction macro info#62

Merged
jackchuma merged 2 commits into
mainfrom
jack/clean-macros
Aug 16, 2025
Merged

fix(CHAIN-1873): remove unused instruction macro info#62
jackchuma merged 2 commits into
mainfrom
jack/clean-macros

Conversation

@jackchuma

Copy link
Copy Markdown
Collaborator

Fixes: The following arguments in the instruction macro can be removed as they are never used:

total_leaf_count from RegisterOutputRoot

The entire macro from BridgeWrappedTokenWithBufferedCall

@cb-heimdall

cb-heimdall commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
@jackchuma jackchuma requested a review from mdehoog August 15, 2025 23:03
@jackchuma jackchuma merged commit 244cf33 into main Aug 16, 2025
3 checks passed
@jackchuma jackchuma deleted the jack/clean-macros branch August 16, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants