Skip to content

Gate sensitive setters and initializers and factorize errors in single file#148

Merged
xenoliss merged 6 commits into
mainfrom
bo/solana
Oct 16, 2025
Merged

Gate sensitive setters and initializers and factorize errors in single file#148
xenoliss merged 6 commits into
mainfrom
bo/solana

Conversation

@xenoliss

Copy link
Copy Markdown
Contributor

Bridge Program:

  • The initialize instruction can only be called by the upgrade authority (deployer)
  • Sensitive config setters can only be called by the upgrade authority
  • The guardian can still call non-sensitive config setters (gas, EIP-1559 config, etc.)
  • Merged all errors into a single BridgeError enum in errors.rs

Base Relayer Program:

  • The initialize instruction can only be called by the upgrade authority (deployer)
  • Merged all errors into a single RelayerError enum in errors.rs
@cb-heimdall

cb-heimdall commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
Comment thread solana/programs/bridge/src/common/instructions/config/mod.rs Outdated
Comment thread solana/programs/bridge/src/common/instructions/guardian.rs Outdated
Comment thread solana/programs/bridge/src/common/instructions/initialize.rs Outdated
Comment thread solana/programs/bridge/src/common/internal/metadata.rs Outdated
Comment thread solana/programs/bridge/src/common/state/bridge.rs Outdated
Comment thread solana/programs/base_relayer/src/test_utils/mod.rs Outdated
Comment thread solana/programs/bridge/src/test_utils/mod.rs Outdated
@xenoliss xenoliss requested a review from jackchuma October 16, 2025 15:50
@xenoliss xenoliss merged commit a1d9a09 into main Oct 16, 2025
6 of 7 checks passed
@xenoliss xenoliss deleted the bo/solana branch October 16, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants