[chore] Map error for getting function#27
Merged
Merged
Conversation
taobun
approved these changes
Jun 2, 2026
There was a problem hiding this comment.
Pull request overview
This PR aims to avoid a runtime panic when resolving the VM entry function from a Wasmer instance by turning the failure into a structured Error, and it also adjusts the VM crate’s dependency constraints and CI setup.
Changes:
- Replace a
unwrap()oninstance.exports.get_function(...)with error mapping. - Add multiple direct dependencies with version ranges in
owasm-vm(apparently to constrain transitive dependency resolution). - Pin CI Rust toolchain to 1.76 and bump
actions/cacheto v4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/vm/src/calls.rs | Converts entry function resolution from panic-on-error to returning a VM Error. |
| packages/vm/Cargo.toml | Adds dependency constraints / additional deps that affect the crate’s resolved dependency graph. |
| .github/workflows/ci.yaml | Pins CI Rust toolchain version and updates the cache action version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satawatnack
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)