node: fix machine id not being a UUID in some cases#356
Open
perf2711 wants to merge 1 commit into
Open
Conversation
perf2711
force-pushed
the
bugfix/node-machine-uuid
branch
from
6b78af8 to
5dc0b2c
Compare
perf2711
force-pushed
the
bugfix/node-machine-uuid
branch
from
5dc0b2c to
5db3458
Compare
konraddysput
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, like on Linux, the returned machine ID may not be a GUID, but a hostname:
This change makes sure that non-GUID results are hashed and returned as GUIDs.