Use last_over_time to fix build_info query #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brettimus
added a commit
to autometrics-dev/autometrics-py
that referenced
this pull request
May 10, 2023
brettimus
added a commit
to autometrics-dev/autometrics-py
that referenced
this pull request
May 11, 2023
* Add blurb to readme about identifying commits * Remove "coming soon" from readme item on adding links to live Prom charts * Initialize Prometheus Gauge for build_info * Add updown counter for build info to otel tracker * Implement set_build_info for OTEL and Prom, and call when we set the default tracker * Move set_build_info call into create_tracker * Update prometheus queries * Update prometheus URL tests * Add test for build_info gauge for prometheus tracker (skipped test for otel tracker) * Update otel tracker and tracker tests after finding otel prometheus bug * Ensure set_build_info is only called once * Update changelog * Add set_build_info to the TrackMetrics Protocol * Fix build_info query based off of autometrics-dev/autometrics-shared#8 * Rename create_tracker to init_tracker * Update pyright * Update README to mention OpenTelemetry tracker does not work with build_info --------- Co-authored-by: Brett Beutell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the version switches, we observed a problem where Prometheus would keep the value of the old gauge in memory and return it for the query using the build_info metric. This is a problem with our group_left query because Prometheus would complain that there are multiple matching label sets (the old and new version info).
Adding the last_over_time function seems to solve this because it seems to get rid of the old gauge value as soon as it no longer appears in the scrape.