Skip to content

fix: use zero-length slice with capacity for EmailTemplates#496

Merged
lakhansamani merged 3 commits into
mainfrom
fix/email-templates-nil-slice
Mar 1, 2026
Merged

fix: use zero-length slice with capacity for EmailTemplates#496
lakhansamani merged 3 commits into
mainfrom
fix/email-templates-nil-slice

Conversation

@lakhansamani
Copy link
Copy Markdown
Contributor

@lakhansamani lakhansamani commented Mar 1, 2026

Summary

  • Changed make([]*model.EmailTemplate, len(emailTemplates)) to make([]*model.EmailTemplate, 0, len(emailTemplates))
  • Eliminates nil-padded entries in the API response

Test plan

  • Verify EmailTemplates query returns correct data without nil entries

Fixes #485
@lakhansamani
fix: use zero-length slice with capacity for EmailTemplates
4580a3c 
The slice was created with len(emailTemplates) nil elements, then
append added more entries after the nil padding. Changed to 0 length
with pre-allocated capacity.

Fixes #485
@lakhansamani
Merge branch 'main' into fix/email-templates-nil-slice
4fe72e4
@lakhansamani
test: add test verifying no nil entries in email templates response
46ecc7e
@lakhansamani lakhansamani merged commit e38d88d into main Mar 1, 2026
@lakhansamani lakhansamani deleted the fix/email-templates-nil-slice branch March 1, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@lakhansamani