Skip to content

[MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty#208

Merged
hboutemy merged 2 commits into
apache:masterfrom
CrazyHZM:MSHADE-462
Jan 31, 2024
Merged

[MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty#208
hboutemy merged 2 commits into
apache:masterfrom
CrazyHZM:MSHADE-462

Conversation

@CrazyHZM

@CrazyHZM CrazyHZM commented Jan 5, 2024

Copy link
Copy Markdown
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…mpty.

Signed-off-by: crazyhzm <crazyhzm@apache.org>
@garydgregory

Copy link
Copy Markdown
Member

Shouldn't we have a unit test to avoid this regression in the first place?

Signed-off-by: crazyhzm <crazyhzm@apache.org>
@CrazyHZM

CrazyHZM commented Jan 6, 2024

Copy link
Copy Markdown
Member Author

Shouldn't we have a unit test to avoid this regression in the first place?

I already add it for this case.

@hboutemy hboutemy merged commit 631371b into apache:master Jan 31, 2024
@hboutemy

Copy link
Copy Markdown
Member

thank you

@CrazyHZM CrazyHZM deleted the MSHADE-462 branch February 1, 2024 03:37
@jira-importer

Copy link
Copy Markdown

Resolve #674

1 similar comment
@jira-importer

Copy link
Copy Markdown

Resolve #674

@olamy olamy added the bug Something isn't working label Sep 9, 2025
@olamy olamy added this to the 3.6.1 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

5 participants