Unimplement PartialEq, PartialOrd from ToRepartition, RePartition#17441
Merged
Conversation
…ion` The implementations of `PartialEq` and `PartialOrd` were not consistent violating the `PartialOrd` contract. These traits are used only to use the `ToRepartition`/`RePartition` in a `BinaryHeap`, so it's easy to fix. However, having type-level partial eq (instead of derived) can be fairly misleading. Instead, these are implemented on a newtype pattern, making the semantics clear.
findepi
deleted the
findepi/unimplement-partialeq-partialord-from-torepartition-repartition-a7502a
branch
September 5, 2025 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementations of
PartialEqandPartialOrdwere not consistent violating thePartialOrdcontract. These traits are used only to use theToRepartition/RePartitionin aBinaryHeap, so it's easy to fix. However, having type-level partial eq (instead of derived) can be fairly misleading. Instead, these are implemented on a newtype pattern, making the semantics clear.PartialOrdforScalarUDF,WindowUDFandAggregateUDF#17064PartialOrdforTDigest'sCentroid#17440