Skip to content

refactor: Split SortMergeJoin into multiple modules#17304

Merged
2010YOUY01 merged 1 commit into
apache:mainfrom
jonathanc-n:split-smj
Aug 26, 2025
Merged

refactor: Split SortMergeJoin into multiple modules#17304
2010YOUY01 merged 1 commit into
apache:mainfrom
jonathanc-n:split-smj

Conversation

@jonathanc-n

@jonathanc-n jonathanc-n commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Splits Sort merge join into exec.rs, stream.rs, metrics.rs

Are these changes tested?

Are there any user-facing changes?
@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Aug 23, 2025
@jonathanc-n

jonathanc-n commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

@2010YOUY01 I was thinking that stream.rs is quite large here. Do you think functions like compare_join_array, is_join_arrays_equal, etc. should be put into utils. I was hesitant since they are only used in SMJ
@2010YOUY01

2010YOUY01 commented Aug 24, 2025

Copy link
Copy Markdown
Contributor

@2010YOUY01 I was thinking that stream.rs is quite large here. Do you think functions like compare_join_array, is_join_arrays_equal, etc. should be put into utils. I was hesitant since they are only used in SMJ

Probably sort_merge_join/utils.rs? But I think it's fine as it is.
2010YOUY01
2010YOUY01 approved these changes Aug 24, 2025
View reviewed changes

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
@2010YOUY01
2010YOUY01 merged commit 7cc54d1 into apache:main Aug 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

2 participants

@jonathanc-n @2010YOUY01