Minor: improve error message when file creation failed#17217
Merged
Conversation
alamb
approved these changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
Thank you @2010YOUY01
Thank you -- this is a nice, pragmatic solution in my mind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
cargo test --test fuzzfails with "Too many open files" #17194Rationale for this change
When running the tests with
cargo test --test fuzz, some spilling execution test might fail under the default file descriptor number limit.I think the failure is system-dependent, some system might have very small default
ulimit, so changing the test case to spill less file might not fix the problem entirely.This PR improves the error message to inform developers to set
ulimit -n 4096when the test fails.If more similar configuration requirements arise in the future, we might consider providing a wrapper around
cargo test.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?