Simplify GetFieldFunc's display_name, schema_name#17167
Merged
xudong963 merged 1 commit intoAug 14, 2025
Merged
Conversation
There is no need to create intermediate `ScalarValue::Utf8` if all we want is the inner value.
findepi
changed the title
GetFieldFunc's display_name, schema_name`GetFieldFunc's display_name, schema_name
xudong963
approved these changes
Aug 14, 2025
findepi
deleted the
findepi/simplify-getfieldfunc-s-display-name-schema-name-195f0d
branch
August 14, 2025 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to create intermediate
ScalarValue::Utf8if all we want is the inner value.