Implement From<Option<String>>' for ScalarValue`#17043
Merged
alamb merged 1 commit intoAug 5, 2025
Merged
Conversation
`ScalarValue` can be made into from a `&str`, `Option<&str>` and `String`. `Option<String>` was a missing alternative.
zhuqi-lucas
approved these changes
Aug 5, 2025
zhuqi-lucas
left a comment
zhuqi-lucas
left a comment
Contributor
There was a problem hiding this comment.
LGTM, this is a clear change, thank you @findepi !
alamb
approved these changes
Aug 5, 2025
Contributor
|
Thanks for the code @findepi and thanks for the review @zhuqi-lucas |
findepi
deleted the
findepi/implement-from-option-string-for-scalarvalue-1c9ad3
branch
August 6, 2025 07:53
hknlof
pushed a commit
to hknlof/datafusion
that referenced
this pull request
Aug 20, 2025
`ScalarValue` can be made into from a `&str`, `Option<&str>` and `String`. `Option<String>` was a missing alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScalarValuecan be made into from a&str,Option<&str>andString.Option<String>was a missing alternative.