test: Add logic tests for string_agg with order#17033
Merged
Merged
Conversation
findepi
approved these changes
Aug 4, 2025
Contributor
|
Thank you @nuno-faria and @findepi |
hknlof
pushed a commit
to hknlof/datafusion
that referenced
this pull request
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
string_aggdoes not respectORDER BYon49.0.0#17011.Rationale for this change
The
string_aggfunction is not considering theORDER BYclause in49.0.0. It has since been fixed.This PR simply adds new sqllogictests to ensure it does not regress in the future.
What changes are included in this PR?
aggregate.slt).Are these changes tested?
Yes.
Are there any user-facing changes?
No.