Fix window_functions docs formatting#17005
Merged
Merged
Conversation
github-actions
Bot
added
the
documentation
alamb
reviewed
Aug 1, 2025
| FROM employees; | ||
| ``` | ||
|
|
||
| ````sql |
Contributor
There was a problem hiding this comment.
What is weird is that this documentation is supposed to be auto generated
This looks like the problem might be that there are two ```sql` blocks there -- let me try and fix it another way...
Contributor
|
I took the liberty of updating the source and rerunning the generation scripts -- I think it still fixes the problem and this way it won't be undone on the next PR Thank you @mattmatravers 🙏 |
alamb
approved these changes
Aug 1, 2025
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @mattmatravers 🙏
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
* Fix window_functions docs formatting * Fix the source and make the docs consistent --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a quick fix while reading the docs page at https://datafusion.apache.org/user-guide/sql/window_functions.html.
Rationale for this change
The Analytical Functions section is malformed.
What changes are included in this PR?
A markdown format fix.
Are these changes tested?
Tested via the github preview page on the PR.
Are there any user-facing changes?
This only affects documentation.