Skip to content

chore: Remove attributes to allow dead_code that aren't relevant anymore#16953

Merged
alamb merged 1 commit into
apache:mainfrom
AdamGS:adamg/remove-allow-dead-code-in-dynamic-filter
Jul 28, 2025
Merged

chore: Remove attributes to allow dead_code that aren't relevant anymore#16953
alamb merged 1 commit into
apache:mainfrom
AdamGS:adamg/remove-allow-dead-code-in-dynamic-filter

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

Just cleans up a couple of #[allow(dead_code)] that aren't relevant anymore

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the physical-expr Changes to the physical-expr crates label Jul 28, 2025

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AdamGS

FYI @adriangb

@alamb
alamb merged commit c3ec964 into apache:main Jul 28, 2025
27 checks passed
@adriangb

Copy link
Copy Markdown
Contributor

Thank you! We should get in the habit of using expect() so that this can picked up automatically 😀

@alamb

alamb commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Thank you! We should get in the habit of using expect() so that this can picked up automatically 😀

It would probably be a good-first-issue ticket to change all #allow( to #expect

Standing-Man pushed a commit to Standing-Man/datafusion that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

3 participants