Add Fetch Property to OutputRequirementExec#16892
Merged
Merged
Conversation
Contributor
Author
|
I'll add a test if I can reproduce a failing case |
alamb
approved these changes
Jul 24, 2025
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Again, this one makes sense to me, though I do wonder if we should add some sort of tests or something to make sure it doesn't get broken accidentally
Contributor
|
is it okay to be merged or we waiting for the test ? |
Contributor
It is ok in my opinion, but let's wait to see if @berkaysynnada has any thoughts |
Contributor
Author
|
We don't want to risk discovering a feature breakage later in downstream projects but let's merge this now. Once I'm able to reproduce the case, I'll open a follow-up PR with the necessary tests ASAP |
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* ore fetch * Update output_requirements.rs
Standing-Man
pushed a commit
to Standing-Man/datafusion
that referenced
this pull request
Aug 4, 2025
* ore fetch * Update output_requirements.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In some of our use cases,
OutputRequirementExecrequires fetch capability during planning. I believe including this functionality upstream would benefit everyone.What changes are included in this PR?
OutputRequirementExec, similar to many other operators. Since it is not an actual operator converted into a stream, this addition has no runtime effect.Are these changes tested?
Are there any user-facing changes?