Mutable Join Unwind#16883
Merged
Merged
Conversation
alamb
approved these changes
Jul 24, 2025
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Seems like a good change to me
| /// usable after the call, though once a task completes, subsequent calls will continue | ||
| /// to return the same `JoinError`. | ||
| pub async fn join_unwind_mut(&mut self) -> Result<R, JoinError> { | ||
| self.await.map_err(|e| { |
Contributor
There was a problem hiding this comment.
To avoid code duplication, perhaps we could change join_unwind to call join_unwind_mut ?
| }) | ||
| } | ||
|
|
||
| /// Joins the task using a mutable reference and unwinds the panic if it happens. |
Contributor
There was a problem hiding this comment.
Could you also document what happens if join_unwind_mut is called twice on the same task?
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* Update common.rs * Update common.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When implementing
Streams withSpawnedTaskobjects, thepoll_nextrequires&mut self, but the existingjoin_unwindmethod consumes theSpawnedTask. The newjoin_unwind_mutmethod allows polling task completion status while retaining theSpawnedTaskfor subsequent polls.What changes are included in this PR?
Added
join_unwind_mut(&mut self)method toSpawnedTaskthat mirrors the behavior ofjoin_unwind(self)Are these changes tested?
Are there any user-facing changes?