docs: Fix broken links#16839
Merged
Merged
Conversation
Contributor
|
I've confirmed the URLs you fixed were returning 404. I used the lychee cli link checker which flagged them with a Unlike It also flagged two URLs in /// See <https://duckdb.org/docs/sql/functions/lambda.html>
fn supports_lambda_functions(&self) -> bool {
true
}Fix: https://duckdb.org/docs/stable/sql/functions/lambda /// `ATTACH PART|PARTITION <partition_expr>`
/// Note: this is a ClickHouse-specific operation, please refer to
/// [ClickHouse](https://clickhouse.com/docs/en/sql-reference/statements/alter/pakrtition#attach-partitionpart)
AttachPartition {
// PART is not a short form of PARTITION, it's a separate keyword
// which represents a physical file on disk and partition is a logical entity.
partition: Partition,
},Fix: https://clickhouse.com/docs/sql-reference/statements/alter/partition#attach-partitionpart |
jcsherin
reviewed
Jul 21, 2025
| /// [`table_partition_cols`]: https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/file_format/options.rs#L190 | ||
| /// [`wrap_partition_type_in_dict`]: crate::file_scan_config::wrap_partition_type_in_dict | ||
| /// [`wrap_partition_value_in_dict`]: crate::file_scan_config::wrap_partition_value_in_dict | ||
| /// [`table_partition_cols`]: https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/file_format/options.rs#L87 |
alamb
approved these changes
Jul 21, 2025
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @2010YOUY01 and @jcsherin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
After reviewing #16830, I was trying to setup a CI with
cargo-deadlinksto auto-detect broken links in the doc comments.However, I found it a bit tricky, so in this PR I'm fixing some known broken links. I'll also open an issue to set up such a CI check and try to address it later.
What changes are included in this PR?
Fix broken links in CI
Are these changes tested?
Are there any user-facing changes?