Skip to content

fix: unit test for object_storage#16824

Merged
alamb merged 2 commits into
apache:mainfrom
chenkovsky:fix/s3_ut
Jul 19, 2025
Merged

fix: unit test for object_storage#16824
alamb merged 2 commits into
apache:mainfrom
chenkovsky:fix/s3_ut

Conversation

@chenkovsky

@chenkovsky chenkovsky commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

I have aws s3 configured in my develop env. These two tests fail.

cargo test object_storage::tests::s3_object_store_builder_resolves_region_when_none_provided
cargo test object_storage::tests::s3_object_store_builder_default

thread 'object_storage::tests::s3_object_store_builder_resolves_region_when_none_provided' panicked at datafusion-cli/src/object_storage.rs:746:9:
assertion `left == right` failed
  left: Some("xxxx")
 right: Some("eu-central-1")

What changes are included in this PR?

Set env to a non-existent file to avoid reading the default configuration file

Are these changes tested?

UT

Are there any user-facing changes?

No

@chenkovsky
chenkovsky marked this pull request as draft July 19, 2025 08:24
@chenkovsky
chenkovsky marked this pull request as ready for review July 19, 2025 09:31

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chenkovsky

@alamb alamb added the development-process Related to development process of DataFusion label Jul 19, 2025
@alamb
alamb merged commit 8a3ea87 into apache:main Jul 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

2 participants