[v3-2-test] UI: Use local Monaco editor module instead of CDN (#66647)#67199
Merged
Conversation
* UI: Bundle Monaco editor instead of loading it from CDN * UI: Configure Monaco worker loading for bundled editor * UI: Lazy load Monaco editor configuration * UI: Bundle Monaco editor without changing runtime version * UI: Fix Dag code tab line number selector * UI: Load bundled Monaco workers with Vite worker imports * UI: Handle Monaco editor load failures * UI: Add Monaco Editor license notice * UI: Add Monaco Editor license notice (cherry picked from commit 3a86142)
1 task
parkhojeong
approved these changes
May 19, 2026
Contributor
parkhojeong
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the careful backport.
bbovenzi
approved these changes
May 19, 2026
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
* UI: Bundle Monaco editor instead of loading it from CDN * UI: Configure Monaco worker loading for bundled editor * UI: Lazy load Monaco editor configuration * UI: Bundle Monaco editor without changing runtime version * UI: Fix Dag code tab line number selector * UI: Load bundled Monaco workers with Vite worker imports * UI: Handle Monaco editor load failures * UI: Add Monaco Editor license notice * UI: Add Monaco Editor license notice (cherry picked from commit 3a86142) Co-authored-by: hojeong park <parkhj062@gmail.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
* UI: Bundle Monaco editor instead of loading it from CDN * UI: Configure Monaco worker loading for bundled editor * UI: Lazy load Monaco editor configuration * UI: Bundle Monaco editor without changing runtime version * UI: Fix Dag code tab line number selector * UI: Load bundled Monaco workers with Vite worker imports * UI: Handle Monaco editor load failures * UI: Add Monaco Editor license notice * UI: Add Monaco Editor license notice (cherry picked from commit 3a86142) Co-authored-by: hojeong park <parkhj062@gmail.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 21, 2026
* UI: Bundle Monaco editor instead of loading it from CDN * UI: Configure Monaco worker loading for bundled editor * UI: Lazy load Monaco editor configuration * UI: Bundle Monaco editor without changing runtime version * UI: Fix Dag code tab line number selector * UI: Load bundled Monaco workers with Vite worker imports * UI: Handle Monaco editor load failures * UI: Add Monaco Editor license notice * UI: Add Monaco Editor license notice (cherry picked from commit 3a86142) Co-authored-by: hojeong park <parkhj062@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #66647 — auto-backport failed due to conflicts in
package.jsonandpnpm-lock.yaml.Conflict resolution
package.json: main carried an unrelated bump ofi18next-http-backend(^3.0.2→^3.0.5) on top of UI: Use local Monaco editor module instead of CDN #66647'smonaco-editoraddition. Kept v3-2-test'si18next-http-backend@^3.0.2(scope-of-PR isolation); only addedmonaco-editor@^0.52.2.pnpm-lock.yaml: regenerated from v3-2-test's lockfile + updatedpackage.jsonviapnpm install --lockfile-only. Avoids hand-merging transitive resolution drift (react 19.2.4 vs 19.2.5, monaco-editor 0.52.2 vs 0.53.0, etc. that came in via unrelated main commits).All other files (Monaco component scaffolding, license/notice updates, page integrations) cherry-picked cleanly.