[v3-2-test] Fix remote_task_handler_kwargs passing handler params to RemoteLogIO (#65957)#66440
Merged
Merged
Conversation
…RemoteLogIO (#65957) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>
1 task
vatsrahul1001
pushed a commit
that referenced
this pull request
May 20, 2026
…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split remote_task_handler_kwargs into handler-level params (max_bytes,
backup_count, delay) and IO-level params before the provider if/elif
chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"],
IO params go to the RemoteLogIO constructor.
Previously all kwargs were passed to RemoteLogIO (causing TypeError
for attrs-based classes) and then reset to {}, so handler params
never reached FileTaskHandler.
closes: #58770
Address review feedback: use inspect.signature(FileTaskHandler.init)
to determine which remote_task_handler_kwargs belong to the file handler
vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.
(cherry picked from commit 823b86e)
Co-authored-by: Sadha Chilukoori srchilukoori@gmail.com
Co-authored-by: Sadha Chilukoori ssreddy.8555@gmail.com