Skip to content

[v3-2-test] Fix remote_task_handler_kwargs passing handler params to RemoteLogIO (#65957)#66440

Merged
jscheffl merged 1 commit into
v3-2-testfrom
backport-823b86e-v3-2-test
May 5, 2026
Merged

[v3-2-test] Fix remote_task_handler_kwargs passing handler params to RemoteLogIO (#65957)#66440
jscheffl merged 1 commit into
v3-2-testfrom
backport-823b86e-v3-2-test

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 5, 2026

  • Fix remote_task_handler_kwargs passing handler params to RemoteLogIO

Split remote_task_handler_kwargs into handler-level params (max_bytes,
backup_count, delay) and IO-level params before the provider if/elif
chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"],
IO params go to the RemoteLogIO constructor.

Previously all kwargs were passed to RemoteLogIO (causing TypeError
for attrs-based classes) and then reset to {}, so handler params
never reached FileTaskHandler.

closes: #58770

  • Derive FileTaskHandler params dynamically via inspect instead of hardcoding

Address review feedback: use inspect.signature(FileTaskHandler.init)
to determine which remote_task_handler_kwargs belong to the file handler
vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

  • Move inspect and FileTaskHandler imports to top level

(cherry picked from commit 823b86e)

Co-authored-by: Sadha Chilukoori srchilukoori@gmail.com
Co-authored-by: Sadha Chilukoori ssreddy.8555@gmail.com

…RemoteLogIO (#65957)

* Fix remote_task_handler_kwargs passing handler params to RemoteLogIO

Split remote_task_handler_kwargs into handler-level params (max_bytes,
backup_count, delay) and IO-level params before the provider if/elif
chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"],
IO params go to the RemoteLogIO constructor.

Previously all kwargs were passed to RemoteLogIO (causing TypeError
for attrs-based classes) and then reset to {}, so handler params
never reached FileTaskHandler.

closes: #58770

* Derive FileTaskHandler params dynamically via inspect instead of hardcoding

Address review feedback: use inspect.signature(FileTaskHandler.__init__)
to determine which remote_task_handler_kwargs belong to the file handler
vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

* Move inspect and FileTaskHandler imports to top level

---------
(cherry picked from commit 823b86e)

Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com>
Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>
@jscheffl jscheffl marked this pull request as ready for review May 5, 2026 19:11
@jscheffl jscheffl merged commit ce51bd9 into v3-2-test May 5, 2026
1 check was pending
@jscheffl jscheffl deleted the backport-823b86e-v3-2-test branch May 5, 2026 19:11
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.2.2 milestone May 18, 2026
@vatsrahul1001 vatsrahul1001 added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…RemoteLogIO (#65957) (#66440)

* Fix remote_task_handler_kwargs passing handler params to RemoteLogIO

Split remote_task_handler_kwargs into handler-level params (max_bytes,
backup_count, delay) and IO-level params before the provider if/elif
chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"],
IO params go to the RemoteLogIO constructor.

Previously all kwargs were passed to RemoteLogIO (causing TypeError
for attrs-based classes) and then reset to {}, so handler params
never reached FileTaskHandler.

closes: #58770

* Derive FileTaskHandler params dynamically via inspect instead of hardcoding

Address review feedback: use inspect.signature(FileTaskHandler.__init__)
to determine which remote_task_handler_kwargs belong to the file handler
vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

* Move inspect and FileTaskHandler imports to top level

---------
(cherry picked from commit 823b86e)

Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com>
Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants