Use contextlib.suppress instead of try-except-pass and re-enable SIM105 (#66193)#66264
Merged
Merged
Conversation
…05 (apache#66193) Signed-off-by: ColtenOuO <jun930436@gmail.com> (cherry picked from commit 251fe92)
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
kaxil,
potiuk and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:API
3 tasks
potiuk
added a commit
that referenced
this pull request
May 2, 2026
…viders (#66178) (#66280) * Use contextlib.suppress instead of try-except-pass in providers (#66178) Signed-off-by: ColtenOuO <jun930436@gmail.com> (cherry picked from commit 9b9789a) * Use contextlib.suppress for try-except-pass in spark_jdbc_script `spark_jdbc_script.py` still has the `try-except-pass` pattern that SIM105 flags. On `main` this file was rewritten in #64174 to raise an explicit `AirflowOptionalProviderFeatureException` instead, but that larger change is out of scope for v3-2-test. Apply the minimum SIM105-compliant edit (`contextlib.suppress(ImportError)`) so the rule re-enabled in #66264 stops failing on this file. --------- Signed-off-by: ColtenOuO <jun930436@gmail.com> Co-authored-by: Colten <70793703+ColtenOuO@users.noreply.github.com>
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
pushed a commit
that referenced
this pull request
May 20, 2026
…viders (#66178) (#66280) * Use contextlib.suppress instead of try-except-pass in providers (#66178) Signed-off-by: ColtenOuO <jun930436@gmail.com> (cherry picked from commit 9b9789a) * Use contextlib.suppress for try-except-pass in spark_jdbc_script `spark_jdbc_script.py` still has the `try-except-pass` pattern that SIM105 flags. On `main` this file was rewritten in #64174 to raise an explicit `AirflowOptionalProviderFeatureException` instead, but that larger change is out of scope for v3-2-test. Apply the minimum SIM105-compliant edit (`contextlib.suppress(ImportError)`) so the rule re-enabled in #66264 stops failing on this file. --------- Signed-off-by: ColtenOuO <jun930436@gmail.com> Co-authored-by: Colten <70793703+ColtenOuO@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #66193
(cherry picked from commit 251fe92)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.