Skip to content

[v3-2-test] Fix bulk task instance rbac bypass (#64288)#65846

Merged
potiuk merged 1 commit into
apache:v3-2-testfrom
potiuk:backport-bulk-task-instance-rbac-to-v3-2-test
Apr 25, 2026
Merged

[v3-2-test] Fix bulk task instance rbac bypass (#64288)#65846
potiuk merged 1 commit into
apache:v3-2-testfrom
potiuk:backport-bulk-task-instance-rbac-to-v3-2-test

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Apr 25, 2026

Backport of #64288 to v3-2-test so the bulk task-instance RBAC check ships in 3.2.2 as well as on main.

The cherry-pick had one trivial conflict in airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py — the original PR's three new tests (test_bulk_update_mapped_task_instance_state_is_persisted, test_bulk_task_instances_rejects_unauthorized_dag_ids_from_request_body, test_bulk_delete_rejects_unauthorized_dag_ids_from_request_body) inserted before test_should_respond_401, and v3-2-test's file structure at that location differs slightly. Resolved by accepting the incoming side; the new tests now sit before the existing test_should_respond_401 test.

Auto-regenerated companion files (_private_ui.yaml, schemas.gen.ts, types.gen.ts) included as produced by the pre-commit hooks.

Local pytest collection fails on this v3-2-test working directory due to an unrelated provider-discovery glitch (No module named 'airflow.providers.vespa.get_provider_info'); CI will run the full suite. The cherry-pick is syntactically clean (verified via python -m ast) and the diff is identical to the original PR's diff modulo the conflict-resolution context.

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Opus 4.7 (1M context)

Generated-by: Claude Opus 4.7 (1M context) following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions

* Fix bulk task instance RBAC checks across DAGs

* Update tests

* fix up tests

* Fixup tests

* Resolve comments

(cherry picked from commit a1c45b9)
@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Apr 25, 2026
@potiuk potiuk added this to the Airflow 3.2.2 milestone Apr 25, 2026
@potiuk potiuk merged commit d778503 into apache:v3-2-test Apr 25, 2026
35 checks passed
@potiuk potiuk deleted the backport-bulk-task-instance-rbac-to-v3-2-test branch April 25, 2026 18:18
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
* Fix bulk task instance RBAC checks across DAGs

* Update tests

* fix up tests

* Fixup tests

* Resolve comments

(cherry picked from commit a1c45b9)

Co-authored-by: GPK <gopidesupavan@gmail.com>
@vatsrahul1001 vatsrahul1001 added the type:bug-fix Changelog: Bug Fixes label May 19, 2026
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
* Fix bulk task instance RBAC checks across DAGs

* Update tests

* fix up tests

* Fixup tests

* Resolve comments

(cherry picked from commit a1c45b9)

Co-authored-by: GPK <gopidesupavan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes

3 participants