Skip to content

fix(DagCalendarTab): improve background color retrieval and loading overlay handling#64189

Merged
bbovenzi merged 34 commits into
apache:mainfrom
MFWhen:dag-calandar-tab
Apr 7, 2026
Merged

fix(DagCalendarTab): improve background color retrieval and loading overlay handling#64189
bbovenzi merged 34 commits into
apache:mainfrom
MFWhen:dag-calandar-tab

Conversation

@MFWhen
Copy link
Copy Markdown
Contributor

@MFWhen MFWhen commented Mar 24, 2026

Refactor Playwright page object for the DAG Calendar Tab to use getComputedStyle and web-first assertions


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Github Copilot following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Mar 24, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 24, 2026
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Outdated
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Outdated
@MFWhen MFWhen changed the title fix(DagCalendarTab): improve background color retrieval and loading o… fix(DagCalendarTab): improve background color retrieval and such Mar 27, 2026
@MFWhen MFWhen changed the title fix(DagCalendarTab): improve background color retrieval and such fix(DagCalendarTab): improve background color retrieval Mar 27, 2026
@eladkal eladkal added this to the Airflow 3.2.1 milestone Mar 28, 2026
@eladkal eladkal added type:bug-fix Changelog: Bug Fixes backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch labels Mar 28, 2026
@MFWhen MFWhen changed the title fix(DagCalendarTab): improve background color retrieval fix(DagCalendarTab): improve background color retrieval and loading overlay handling Mar 28, 2026
@jscheffl
Copy link
Copy Markdown
Contributor

If you make UI changes it is always very good for reviewers to have a "before" and "after" ascreenshot. Or a video showing the change. Can you add this to the PR?

@MFWhen MFWhen force-pushed the dag-calandar-tab branch from 22a3153 to 9a1dee1 Compare March 29, 2026 18:46
@MFWhen
Copy link
Copy Markdown
Contributor Author

MFWhen commented Mar 30, 2026

If you make UI changes it is always very good for reviewers to have a "before" and "after" ascreenshot. Or a video showing the change. Can you add this to the PR?

Hello,

There are no visual differences in the ui for this code. The change is limited to Playwright e2e test refactoring (locators/waits/assertions).

@choo121600
Copy link
Copy Markdown
Member

yes, no need to include screenshots 👍
However, it looks like the CI is failing—could you please take a look?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily targets Playwright E2E stability around the DAG Calendar tab by changing how the page object waits for “ready” states and how it derives calendar cell background colors. It also introduces a new developer script intended to automate updates to .github/ branch-related configuration when a new release branch is created.

Changes:

  • Refactors DagCalendarTab E2E page-object waits to use Playwright web-first assertions and adjusts calendar readiness logic.
  • Changes background color retrieval logic for active calendar cells in E2E tests.
  • Adds dev/update_github_branch_config.py to automate updating several .github/ configs and docs when creating a new vX-Y-test branch.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File Description
dev/update_github_branch_config.py New automation script for updating branch-related GitHub configs and docs.
airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Updates calendar E2E page-object waiting strategy and active-cell color extraction.
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
Comment thread airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts Outdated
MFWhen and others added 4 commits April 2, 2026 10:34
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MFWhen MFWhen marked this pull request as ready for review April 2, 2026 14:59
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026
Copy link
Copy Markdown
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

Comment thread dev/update_github_branch_config.py
@bbovenzi bbovenzi merged commit a02fbaa into apache:main Apr 7, 2026
82 checks passed
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Apr 7, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test Commit Link

You can attempt to backport this manually by running:

cherry_picker a02fbaa v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

shivaam pushed a commit to shivaam/airflow that referenced this pull request Apr 8, 2026
…verlay handling (apache#64189)

* fix(DagCalendarTab): improve background color retrieval and loading overlay handling

* fix(DagCalendarTab): update loading overlay and calendar cell visibility checks

* fix(DagCalendarTab): improve background color retrieval and loading overlay handling

* fix(DagCalendarTab): update loading overlay and calendar cell visibility checks

* refactor: update visibility checks in DagCalendarTab

* remove redundant visibility checks in DagCalendarTab

* removed unrelated change and attempted to resolve merge conflict markers

* Update airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* updated getActiveCellColors to use getComputedStyle to properly return rendered color of an element

* simplify child element color retrieval and improve readability

* changed file mode

---------

Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vatsrahul1001
Copy link
Copy Markdown
Contributor

Manual backport PR #66860 up for review @choo121600 @bbovenzi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch ready for maintainer review Set after triaging when all criteria pass. type:bug-fix Changelog: Bug Fixes

8 participants