Skip to content

Update pools slot input#63900

Merged
bbovenzi merged 3 commits into
apache:mainfrom
astronomer:fix-pool-slots
Mar 24, 2026
Merged

Update pools slot input#63900
bbovenzi merged 3 commits into
apache:mainfrom
astronomer:fix-pool-slots

Conversation

@bbovenzi
Copy link
Copy Markdown
Contributor

Closes #63846

Screenshot 2026-03-18 at 3 39 21 PM

Add validators to the slot pools input instead of falling back to using the previous valid form value which caused confusing behavior.


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.
Comment thread airflow-core/src/airflow/ui/src/pages/Pools/PoolForm.tsx
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside Kaxil suggestion improvement.

@bbovenzi bbovenzi merged commit ee2e5d2 into apache:main Mar 24, 2026
79 of 80 checks passed
@bbovenzi bbovenzi deleted the fix-pool-slots branch March 24, 2026 17:27
github-actions Bot pushed a commit that referenced this pull request Mar 24, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
(cherry picked from commit ee2e5d2)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: v3-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test PR Link
bbovenzi added a commit that referenced this pull request Mar 24, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
(cherry picked from commit ee2e5d2)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
vatsrahul1001 pushed a commit that referenced this pull request Mar 25, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
vatsrahul1001 pushed a commit that referenced this pull request Mar 25, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
(cherry picked from commit ee2e5d2)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Mar 30, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
abhijeets25012-tech pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Apr 9, 2026
* Update pools slot input

* Simplify

* Add validation for <-1
@potiuk potiuk added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 26, 2026
potiuk added a commit that referenced this pull request Apr 26, 2026
* Update pools slot input

* Simplify

* Add validation for <-1

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
* Update pools slot input

* Simplify

* Add validation for <-1

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
* Update pools slot input

* Simplify

* Add validation for <-1

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch translation:default

5 participants