Make execution_date_or_run_id optional in tasks test command

[dstandish]

No description provided.

[dimberman]

Do you not need to delete this?

[dstandish]

it's used elsewhere

[ashb]

What's the reason for this? Because right now everything in Airflow task execution is for a specific date,

So given airflow tasks test example_python_operator print_the_context what will it print for logical_date, or data_interval_start?

Do any docs need updating too?

[dstandish]

What's the reason for this? Because right now everything in Airflow task execution is for a specific date,

Right, it's always "there" for airlfow, at least internally. But often times as a task developer you don't care about the execution_date. E.g. when catchup=False, probably you aren't really concerned with it. For those cases, it's nice to just be able to run the task and not have to pick an arbitrary date you don't care about, just so you can run your task via CLI.

So given airflow tasks test example_python_operator print_the_context what will it print for logical_date, or data_interval_start?

Should be same as if you put today UTC in for execution_date.

Do any docs need updating too?

i'll take a look.

[dstandish]

did make the small adjustments required in the docs. and i think it will build green now -- was just a static check remaining.

resolved the comment

[jedcunningham]

If we make this default session change, should we also @provide_session this?

[dstandish]

i don't see why the one should prompt the other. the NEW_SESSION change doesn't really change the behavior of the function. the reason it's there in general is this:

# A fake session to use in functions decorated by provide_session. This allows
# the 'session' argument to be of type Session instead of Optional[Session],
# making it easier to type hint the function body without dealing with the None
# case that can never happen at runtime.

but for me, i'm adding it here simply because i want to keep it as the last argument, so to do so, it needs a default, since i'm making exec date optional.

but what do you think?

[uranusjr]

All arguments in this function are keyword-only, so ordering does not matter. You can add the new argument anywhere (but behind *) and keep all other arguments as-is.

[dstandish]

@ashb has previously requested that we keep session as the last argument 🤷

@ashb ?

[uranusjr]

You can keep it last, keyword-only means you don’t need to add a default to keep it last.

[dstandish]

🤯